Set the correct base config module for salt-migration-minion #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NamelessOne91
force-pushed
the
fix_base_config_module
branch
from
0c568b1 to
66281b3
Compare
NamelessOne91
force-pushed
the
fix_base_config_module
branch
from
66281b3 to
acb7395
Compare
srbarrios
reviewed
Jan 4, 2024
| source = "./modules/minion" | ||
| base_configuration = module.base.configuration | ||
| source = "./modules/minion" | ||
| base_configuration = module.base_core.configuration |
There was a problem hiding this comment.
I would better use the same base for all the terraform files, base_new_sle is fine.
But please, avoid using base_core, having this setup, will deploy this VM together with the server and other core components on the same KVM host (aka hypervisor), and we want to keep core components as much isolated as possible.
There was a problem hiding this comment.
what you say is true for PRV, not for NUE, where we have only one hypervisor
srbarrios
reviewed
Jan 4, 2024
| source = "./modules/minion" | ||
| base_configuration = module.base.configuration | ||
| source = "./modules/minion" | ||
| base_configuration = module.base_core.configuration |
Bischoff
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title - It was pointing to a non-existent "base" module