Let sumaform tests pass with the s390 provider #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bischoff
force-pushed
the
test
branch
30 times, most recently
from
e74b8af to
9871e70
Compare
Bischoff
force-pushed
the
test
branch
22 times, most recently
from
44ad154 to
8434fe0
Compare
Bischoff
changed the title
srbarrios
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One design problem of current sumaform is that we can have only one backend symlink for all modules.
The sumaform tests on github actions set this symlink to the null provider, but the s390 module still points to the s390 provider for its backend.
This PR solves the issue by installing the s390 provider and tweaking the tf files a bit more.