Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new HEAD BV #1072

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Add a new HEAD BV #1072

merged 1 commit into from
Jan 23, 2024

Conversation

nodeg
Copy link
Member

@nodeg nodeg commented Jan 12, 2024 •
edited
Loading

Description

This will add new pipelines and terraform configuration files for a new HEAD/5.0 BV.

  • According to Cedric we do not need the Helm charts for SUMA/5.0.

TODO

See https://github.com/SUSE/spacewalk/issues/23078

@nodeg nodeg self-assigned this Jan 12, 2024
@nodeg nodeg force-pushed the head_bv branch 4 times, most recently from 26978d6 to 8f7c2b8 Compare January 12, 2024 14:32
@srbarrios srbarrios requested a review from a team January 17, 2024 13:35
@srbarrios
Copy link
Member

srbarrios commented Jan 17, 2024 •
edited
Loading

I think... we should better call it 5.0 directly, instead of using the word HEAD.
We will for now use Head for sure, but in a few months, we want this pipeline and this infrastructure to test the MUs of 5.0, we don't want to spend time creating another different environment, and also we don't expect to test Head after GM.
Also, having 5.0 on the name will be better aligned to what we also have on fqdn.

@nodeg nodeg marked this pull request as ready for review January 17, 2024 16:30
@nodeg nodeg requested a review from a team January 17, 2024 16:30
@nodeg nodeg requested a review from maximenoel8 January 18, 2024 11:52
@nodeg nodeg requested a review from maximenoel8 January 19, 2024 09:59
Bischoff
Bischoff requested changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@Bischoff Bischoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

Cédric apparently also has unresolved comments

jenkins_pipelines/environments/manager-5.0-qe-build-validation-NUE Show resolved Hide resolved
jenkins_pipelines/environments/manager-5.0-qe-build-validation-PRV Show resolved Hide resolved
terracumber_config/tf_files/SUSEManager-5.0-build-validation-NUE.tf Show resolved Hide resolved
terracumber_config/tf_files/SUSEManager-5.0-build-validation-NUE.tf Show resolved Hide resolved
terracumber_config/tf_files/SUSEManager-5.0-build-validation-NUE.tf Show resolved Hide resolved
terracumber_config/tf_files/SUSEManager-5.0-build-validation-NUE.tf Show resolved Hide resolved
terracumber_config/tf_files/SUSEManager-5.0-build-validation-NUE.tf Show resolved Hide resolved
terracumber_config/tf_files/SUSEManager-5.0-build-validation-NUE.tf Show resolved Hide resolved
terracumber_config/tf_files/SUSEManager-5.0-build-validation-PRV.tf Show resolved Hide resolved
terracumber_config/tf_files/SUSEManager-5.0-build-validation-PRV.tf Show resolved Hide resolved
maximenoel8
maximenoel8 requested changes Jan 21, 2024
View reviewed changes
terracumber_config/tf_files/SUSEManager-5.0-build-validation-NUE.tf
container_repository = "registry.suse.de/devel/galaxy/manager/head/containers/suse/manager/5.0/server"
helm_chart_url = "oci://registry.suse.de/devel/galaxy/manager/head/charts/suse/manager/5.0/server-helm"

server_mounted_mirror = "minima-mirror-ci-bv.mgr.suse.de"
Copy link
Contributor

@maximenoel8 maximenoel8 Jan 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are probably missing a disk for the reposync. The host disk will be quickly full. I don't know how it will be managed at the container level
repository_disk_size = 2048

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see on sumaform side that repository_disk_size is not supported. I wonder how we can synchronize all the repositories for BV without this disk.

Copy link
Member Author

@nodeg nodeg Jan 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. This is as of now only available for the normal server module. @cbosdo do you know how this would be handled for the container? I think a simple copy-paste of the server additional_disks.sls will not do the trick.

@nodeg nodeg requested a review from Bischoff January 22, 2024 13:58
Bischoff
Bischoff requested changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@Bischoff Bischoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 remaining issues

terracumber_config/tf_files/SUSEManager-5.0-build-validation-NUE.tf Outdated Show resolved Hide resolved
terracumber_config/tf_files/SUSEManager-5.0-build-validation-NUE.tf Show resolved Hide resolved
terracumber_config/tf_files/SUSEManager-5.0-build-validation-NUE.tf Outdated Show resolved Hide resolved
terracumber_config/tf_files/SUSEManager-5.0-build-validation-PRV.tf Outdated Show resolved Hide resolved
terracumber_config/tf_files/SUSEManager-5.0-build-validation-PRV.tf Outdated Show resolved Hide resolved
@Bischoff Bischoff requested review from Bischoff and removed request for Bischoff January 22, 2024 14:32
Bischoff
Bischoff approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@Bischoff Bischoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the huge effort, Dominik

maximenoel8
maximenoel8 approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@maximenoel8 maximenoel8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work Dominik. I will approve. We will need to manage this extra disk in an other PR.

@nodeg
Copy link
Member Author

nodeg commented Jan 23, 2024

Thank you, Maxime. I also think this is a reasonable approach.

@nodeg
Add a new 5.0/HEAD BV
3a9d947 
To be able to test 5.0 further, we decided to add a new 5.0 BV.

See SUSE/spacewalk#23078

Signed-off-by: Dominik Gedon <[email protected]>
@nodeg
Copy link
Member Author

nodeg commented Jan 23, 2024

Squash and rebase done.

@nodeg nodeg merged commit 69cdc45 into SUSE:master Jan 23, 2024
1 check passed
@nodeg nodeg deleted the head_bv branch January 23, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NamelessOne91 NamelessOne91 NamelessOne91 approved these changes

@srbarrios srbarrios srbarrios left review comments

@cbosdo cbosdo cbosdo left review comments

@maximenoel8 maximenoel8 maximenoel8 approved these changes

@ktsamis ktsamis ktsamis approved these changes

@Bischoff Bischoff Bischoff approved these changes

Assignees

@nodeg nodeg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nodeg @srbarrios @cbosdo @Bischoff @ktsamis @maximenoel8 @NamelessOne91