Merge pull request #3 from fztr/fztr-fix-on-current-line

Fixes bug in onCurrentLine and adds corresponding test
SabakiHQ · Jan 15, 2021 · 0b74ca3 · 0b74ca3
2 parents 4424e56 + fb30be7
commit 0b74ca3
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 1 deletion.
diff --git a/src/GameTree.js b/src/GameTree.js
@@ -257,7 +257,6 @@ class GameTree {
 
   onCurrentLine(id, currents) {
     for (let node of this.listNodesVertically(id, -1, {})) {
-      if (node.id === id) continue
       let {parentId} = node
 
       if (

diff --git a/tests/GameTree.test.js b/tests/GameTree.test.js
@@ -165,6 +165,7 @@ t.test('onCurrentLine method', t => {
   t.equal(tree.onCurrentLine(tree.root.id, {}), true)
   t.equal(tree.onCurrentLine(subChildId1, {[id1]: childId2}), false)
   t.equal(tree.onCurrentLine(subChildId1, {[id1]: childId3}), true)
+  t.equal(tree.onCurrentLine(childId1, {[id1]: childId2}), false)
 
   t.end()
 })