Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Multiple Programming Language Courses #1474

Merged
merged 24 commits into from
Aug 5, 2023

Conversation

GauriBhandari
Copy link
Contributor

@GauriBhandari GauriBhandari commented Jul 29, 2023

πŸ› οΈ Fixes Issue

Issue- #1468

πŸ‘¨β€πŸ’» Changes proposed

I have added courses for the programming languages, catering to diverse learners and industry demands.
Added courses for the following programming languages:

  1. Java
  2. React
  3. Python
  4. Rust
  5. Shell
  6. SQL
  7. Typescript
  8. PHP
  9. Scala
  10. Perl
  11. Lisp

If there are any specific programming languages or technology domains that you believe would be beneficial to include, I'd be more than happy to work on expanding the course catalog. If there are any guidelines or preferences regarding course additions, please let me know.

Thank you for your time and consideration. I'm looking forward to your feedback.

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

@netlify
Copy link

netlify bot commented Jul 29, 2023

βœ… Deploy Preview for aec-library-wbsite ready!

Name Link
πŸ”¨ Latest commit 6e4f7f6
πŸ” Latest deploy log https://app.netlify.com/sites/aec-library-wbsite/deploys/64c800703251380008c3c4e8
😎 Deploy Preview https://deploy-preview-1474--aec-library-wbsite.netlify.app/resource
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rohanbabbar04
Copy link
Collaborator

  • Look into this, there are some broken image links...
  • Also I don't think you additions match the pattern we are trying to implement. I would want the user to move right-left to look for his preferred course I think that looks better, currently it looks crowded.
  • Also make sure the size of images are same...

resource.html Outdated Show resolved Hide resolved
@GauriBhandari
Copy link
Contributor Author

The issue regarding the broken images and the course layout has been resolved. If there are any further improvements needed please let me know.
Thank you!

@GauriBhandari
Copy link
Contributor Author

hi @rohanbabbar04 ,
I hope you're doing well. I just wanted to check in on the status of my Pull Request. It seems that it hasn't been reviewed yet, and I'm eager to receive your feedback on the changes I made.

resource.html Outdated Show resolved Hide resolved
@rohanbabbar04
Copy link
Collaborator

@GauriBhandari In your last commit it seems you are using a formatter, please turn it off and commit...

@GauriBhandari
Copy link
Contributor Author

The latest commit now includes only the relevant changes without any formatting modifications.

@GauriBhandari
Copy link
Contributor Author

hi @rohanbabbar04 ,
I hope you're doing well. I just wanted to check in on the status of my Pull Request. It seems that it hasn't been reviewed yet, and I'm eager to receive your feedback on the changes I made.

@GauriBhandari
Copy link
Contributor Author

hi @rohanbabbar04 ,
I just wanted to check in on the status of my Pull Request. It seems that it hasn't been reviewed yet, and I'm eager to receive your feedback on the changes I made.

@rohanbabbar04
Copy link
Collaborator

Looks good thanks

@rohanbabbar04 rohanbabbar04 merged commit a07510a into SauravMukherjee44:main Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants