Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document actor paths configuration #635

Merged
merged 4 commits into from
Mar 9, 2023

Conversation

mBut
Copy link
Contributor

@mBut mBut commented Mar 8, 2023

Closes #487


Summary:

This PR adds documentation for the akka actors metrics grouping and performs little clean up in the associated codebase.

@mBut mBut requested a review from lgajowy March 8, 2023 13:42

## Mesmer options

### Akka actors grouping
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lgajowy I described the actual behaviour of the current implementation as is, but the implementation it's what bothers me. For most paths definitions there is no distinction between instance and group option behaviour. Similarly different rules can lead to the same results and it's quite confusing which definition is preferred.

I believed the current implementation is the result of incremental evolution of the requirements. I suggest, for some future version of Mesmer, to define and document the exact specification on path matching first and then rewrite the entire matching logic from scratch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yeah. Couldn't frame that better. Thanks for that input!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#636

I created an issue for fixing that


## Mesmer options

### Akka actors grouping
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#636

I created an issue for fixing that

@lgajowy lgajowy merged commit b6553ae into main Mar 9, 2023
@lgajowy lgajowy deleted the 487-document-actor-paths-configuration branch March 9, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document configuration of actorPath attribute in Actor metrics
2 participants