Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derived sensors #3

Merged
merged 5 commits into from
Sep 20, 2021
Merged

Derived sensors #3

merged 5 commits into from
Sep 20, 2021

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Sep 20, 2021

A currently undocumented feature to set up (using a new plugin config setting) additional FlexMeasures sensors whose data is derived from other sensors (that are directly mapped to a Z-info sensor).

@Flix6x Flix6x self-assigned this Sep 20, 2021
@Flix6x Flix6x requested a review from nhoening September 20, 2021 08:12
__init__.py Outdated Show resolved Hide resolved
__init__.py Show resolved Hide resolved
@Flix6x Flix6x requested a review from nhoening September 20, 2021 13:50
@nhoening
Copy link
Contributor

So the derived sensors - are they really z-info sensors? It seems to me they are derived from Z-Info sensors, but really not a representation of any z-info raw data.
So the naming should maybe stick to DERIVED_SENSORS or similar...

@Flix6x
Copy link
Contributor Author

Flix6x commented Sep 20, 2021

I made a ticket to refactor further.

@Flix6x
Copy link
Contributor Author

Flix6x commented Sep 20, 2021

So the derived sensors - are they really z-info sensors? It seems to me they are derived from Z-Info sensors, but really not a representation of any z-info raw data.
So the naming should maybe stick to DERIVED_SENSORS or similar...

It's probably not even necessary to make the distinction once we move to a single config setting. Perhaps the unified config setting could be renamed again to ZINFO_SENSOR_MAPPING.

@Flix6x Flix6x merged commit 69e5b41 into main Sep 20, 2021
@Flix6x Flix6x deleted the derived-sensors branch September 20, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants