Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken HookRegistryTest.php after switching to Language::factory #89

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Fix broken HookRegistryTest.php after switching to Language::factory #89

merged 1 commit into from
Feb 23, 2021

Conversation

gesinn-it-gea
Copy link
Member

This PR is made in reference to: #88

This PR addresses or contains:

  • fix test by using use $pageLang = Language::factory( 'en' );

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Fixes #88

@gesinn-it-gea
Update HookRegistryTest.php
a786055 
use $pageLang = Language::factory( 'en' );
@gesinn-it-gea
Copy link
Member Author

@kghbln if you want to release: all tests are passing now, but please be aware of #86. This is something someone, who is more heavily using SIL than we do, should put some love in :-)

@gesinn-it-gea gesinn-it-gea merged commit 838587b into master Feb 23, 2021
@gesinn-it-gea gesinn-it-gea deleted the issue-88 branch February 23, 2021 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@gesinn-it-gea