Json ld serialization updated #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-topway-it
referenced
this pull request
Jan 10, 2025
paladox
reviewed
Jan 10, 2025
composer.json
Outdated
| @@ -28,7 +28,10 @@ | |||
| }, | |||
| "require": { | |||
| "php": ">=7.4", | |||
| "composer/installers": ">=1.0.1" | |||
| "composer/installers": ">=1.0.1", | |||
| "mediawiki/semantic-media-wiki": "~3.1|~4.0|~5.0", | |||
There was a problem hiding this comment.
Remove this please. It’s unneeded and could be why ci is failing.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #90 +/- ##
=============================================
- Coverage 97.35% 83.40% -13.95%
- Complexity 67 80 +13
=============================================
Files 6 7 +1
Lines 189 223 +34
=============================================
+ Hits 184 186 +2
- Misses 5 37 +32 ☔ View full report in Codecov by Sentry. |
|
@paladox any update about this ? |
|
Oh, I'm leaving this to @JeroenDeDauw (or anyone who maintains this extension?) since this is a new feature and I'm not too familiar with the extension. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebased version of #80
(adds json-ld serialization using https://github.com/easyrdf/easyrdf from SMW's standard RDF serialization)
see also easyrdf/easyrdf#408