overhauled argument parsing

[byt3bl33d3r]

Hi,
I re-wrote the argument parsing section of the script using the python argparse library, cuts down the code by a significant amount.. I haven't tried all of the options to see if everything works as before only because its getting late over here :P, so before merging your definitely going to want to test everything out!
Also fixed the shebang to be friendlier when multiple python versions are installed.
Again, awesome script man!

Cheers

[ShawnDEvans]

You seriously rule man!! I'll test out the features in my VM lab. This
was on my to do list, but I never used that library or realized it existed
until it was too late. Thanks a ton for the contribution!!

Shawn
On Apr 28, 2015 7:41 PM, "byt3bl33d3r" [email protected] wrote:

Hi,
I re-wrote the argument parsing section of the script using the python
argparse library, cuts down the code by a significant amount.. I haven't
tried all of the options to see if everything works as before only because
its getting late over here :P, so before merging your definitely going to
want to test everything out!
Also fixed the shebang to be friendlier when multiple python versions are
installed.
Again, awesome script man!

Cheers

You can view, comment on, or merge this pull request online at:

#4
Commit Summary

• Fixed shebang

File Changes

• M smbmap.py
  https://github.com/ShawnDEvans/smbmap/pull/4/files#diff-0 (359)

Patch Links:

• https://github.com/ShawnDEvans/smbmap/pull/4.patch
• https://github.com/ShawnDEvans/smbmap/pull/4.diff

—
Reply to this email directly or view it on GitHub
#4.

[ShawnDEvans]

Hey,

Thanks again for putting in the work to get the ArgumentParser working! I tested all of the functionality, and had to make a few changes to the code you revised. I'm a bit new to using "git" on the command line. I ended up just using "--force" to force a push. For future reference, how do I correctly make changes to your code suggestions, push my changes back to your branch, and eventually to the master branch? I want to make sure you're recognized as a contributor. Thanks a ton!

-Shawn

[byt3bl33d3r]

Hi shawn,
Glad you got it all sorted out!
There isn't a 'direct' way of changing the code in my fork since you don't have access to my repo.
What I usually do is this (there might be a better way):

• In your repo, create a new branch git checkout -b branchname
• Pull my commits into the new branch git pull https://github.com/byt3bl33d3r/smbmap.git
• Now you can modify my changes all you want
• When you want to merge the changes, switch back to the master branch git checkout master
• Merge the changes git merge branchname
• Then commit and push