.NET 8 trying to fix #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added GITHUB link
Changing lots of Unit tests from Assert.True to proper ones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added CA1416 to the ignore list, this warns about that parts of TMC code dont work outside Windows machines.
I tried to remove all of these errors:
A violation of this rule occurs when Assert.True or Assert.False are used with string.Equals to check if two strings are equal.
https://xunit.net/xunit.analyzers/rules/xUnit2010
A violation of this rule occurs when Enumerable.Any is used to check if a value matching a predicate exists in a collection.
https://xunit.net/xunit.analyzers/rules/xUnit2012