Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config option for radiation #3988

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Add config option for radiation #3988

merged 2 commits into from
Dec 5, 2023

Conversation

iTwins
Copy link
Contributor

@iTwins iTwins commented Oct 5, 2023

Description

There was some discussion about people wanting to disable radiation.

Proposed changes

Add a config option that controls whether the radiation task will be scheduled.

Related Issues (if applicable)

N/A

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@iTwins iTwins requested a review from a team as a code owner October 5, 2023 16:32
@github-actions github-actions bot added the 🎈 Feature This Pull Request adds a new feature. label Oct 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Your Pull Request was automatically labelled as: "🎈 Feature"
Thank you for contributing to this project! ❤️

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023 •
edited
Loading

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: 43aa5b97

https://preview-builds.walshy.dev/download/Slimefun/3988/43aa5b97

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

J3fftw1
J3fftw1 previously approved these changes Oct 8, 2023
View reviewed changes
@J3fftw1 J3fftw1 added the hacktoberfest-accepted Manual override to accept a PR for Hacktoberfest label Oct 8, 2023
JustAHuman-xD
JustAHuman-xD approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@JustAHuman-xD JustAHuman-xD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WalshyDev WalshyDev merged commit 6ce0911 into Slimefun:master Dec 5, 2023
13 checks passed
@iTwins iTwins deleted the feature/radiation_toggle branch December 5, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheBusyBiscuit TheBusyBiscuit TheBusyBiscuit left review comments

@JustAHuman-xD JustAHuman-xD JustAHuman-xD approved these changes

@J3fftw1 J3fftw1 J3fftw1 approved these changes

@WalshyDev WalshyDev WalshyDev approved these changes

Assignees
No one assigned
Labels
🎈 Feature This Pull Request adds a new feature. hacktoberfest-accepted Manual override to accept a PR for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iTwins @TheBusyBiscuit @WalshyDev @J3fftw1 @JustAHuman-xD