Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature - Add beginning and ending dates to product label #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Feature - Add beginning and ending dates to product label #56

wants to merge 1 commit into from

Conversation

florent-maissiat-smile
Copy link

Rebased version of #32

In this feature, we wanted to add the possibility of setting a begining date and ending date to show a product label.

To do so, we added two date fields in the database and did the same for the back office. We linked them together and added a simple condition in order to check if the product label should be shown in the storefront.

image image

@PrigentMatthieu PrigentMatthieu mentioned this pull request Mar 31, 2023
Closed
@PierreGauthier
Copy link
Contributor

Thank for you contribution
Can you rebase you branch on master ?

PierreGauthier
PierreGauthier reviewed Sep 27, 2023
View reviewed changes
view/adminhtml/ui_component/smile_productlabel_productlabel_form.xml
<settings>
<validation>
<rule name="validate-date" xsi:type="boolean">true</rule>
<rule name="required-entry" xsi:type="boolean">true</rule>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why make these fields required ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreGauthier PierreGauthier PierreGauthier left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florent-maissiat-smile @PierreGauthier