Improved model creation #224
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-kschmaus
requested review from
sfc-gh-rehuang,
sfc-gh-cnivera and
sfc-gh-jsummer
as code owners
sfc-gh-tzayats
force-pushed
the
customer-eval
branch
from
15fe4b1 to
a61485e
Compare
sfc-gh-kschmaus
force-pushed
the
improved-model-creation
branch
from
4c0984c to
87e8b07
Compare
sfc-gh-kschmaus
force-pushed
the
improved-model-creation
branch
3 times, most recently
from
a4c5e29 to
7d28cd2
Compare
adopt main changes
sfc-gh-kschmaus
force-pushed
the
improved-model-creation
branch
from
7d28cd2 to
9989ead
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies semantic model creation. The main change is enabling support for cortex search service integration. Some small changes are made to AI description generation. This removes the user's selection of the number of sample values. Sample values are removed for non string-columns. For string columns with 8 or less distinct sample values, all are included as sample values. For string columns with more than 8 distinct values, no sample values are used, and the user can setup cortex search service integration for those columns.