SLVSCODE-870 Fix silent failure of deployment to OpenVSX #628
Conversation
|
| @@ -29,10 +31,13 @@ const { | |||
| extensionFile: ARTIFACT_FILE, | |||
| pat: OPENVSX_TOKEN | |||
| }; | |||
| await ovsx.publish(options); | |||
|
|
|||
| const [ publicationResult ] = await ovsx.publish(options); | |||
There was a problem hiding this comment.
This is what caused the silent failure: ovsx.publish returns an array of PromiseSettledResult instead of failing 🤦🏻
There was a problem hiding this comment.
If I'm looking at the correct thing, publish() returns a single Promise<PromiseSettledResult<void>[]>. With the await, we will get the array of settled/unsettled promises.
So I am thinking that we should consider the full array (not only the first element), and check if any of them have been rejected in the if below. 🤔
There was a problem hiding this comment.
In theory, yes; and when I run the script, the array contains only a single result. It could contain several items if we were publishing several packages at once.
There was a problem hiding this comment.
OK, that makes sense!
SLVSCODE-870