Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLVSCODE-746 Use non trivial ID for first level nodes of connected mode view #676

Merged
merged 2 commits into from
Jan 10, 2025
Merged

SLVSCODE-746 Use non trivial ID for first level nodes of connected mode view #676

merged 2 commits into from
Jan 10, 2025

Conversation

jblievremont
Copy link
Member

@jblievremont jblievremont commented Jan 10, 2025 •
edited by jira bot
Loading

sophio-japharidze-sonarsource
sophio-japharidze-sonarsource requested changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the getConnections() suite needs to be updated as well, although I am not sure how did it pass 😃

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
88.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

sophio-japharidze-sonarsource
sophio-japharidze-sonarsource approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jblievremont jblievremont merged commit 2006d43 into master Jan 10, 2025
12 checks passed
@jblievremont jblievremont deleted the SLVSCODE-746-cx-mode-groups-node-ids branch January 10, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophio-japharidze-sonarsource sophio-japharidze-sonarsource sophio-japharidze-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jblievremont @sophio-japharidze-sonarsource