Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3236 #3238

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Fix #3236 #3238

merged 2 commits into from
Jul 31, 2024

Conversation

h-mayorquin
Copy link
Collaborator

It would be nice if someone knew the exact expected behavior of this. The behavior is not documented in matplotilb.get_backend() as far as I can tell but this is how it works in my system:

https://matplotlib.org/stable/api/matplotlib_configuration_api.html#matplotlib.get_backend

Maybe something that changed recently:

image

@h-mayorquin h-mayorquin added bug Something isn't working widgets Related to widgets module labels Jul 19, 2024
@h-mayorquin h-mayorquin self-assigned this Jul 19, 2024
@chrishalcrow
Copy link
Collaborator

Can confirm this fixes the bug on my Linux machine, and doesn't break anything on my Mac.

@zm711
Copy link
Collaborator

zm711 commented Jul 22, 2024

That would explain why I thought it worked fine. I had been doing it all on my mac for this stuff....

@JoeZiminski
Copy link
Collaborator

Can confirm this doesn't break anything on Windows either (could not reproduce #3236 on Windows), interestingly the output is completely different. I'm not sure why it's the same for both backends, I can confirm I have

ipympl 0.9.4
ipywidgets 8.1.3
matplotlib 

and restarting the kernel between the two:

image

image

@zm711
Copy link
Collaborator

zm711 commented Jul 22, 2024

This could be a very specific version issue, I don't which package. Not sure if we want to search for the root since it is so inconsistent or just use this PR to not worry about the assert.

@zm711
Copy link
Collaborator

zm711 commented Jul 22, 2024

Same as @JoeZiminski , I just tested this on Windows and couldn't replicate the issue. I get the same backend as Joe. But if I do %matplotlib ipympl it gives me a warning and says it will automatically switch to widget mode for me. But works fine.

@JoeZiminski
Copy link
Collaborator

Okay that's great @zm711 that it repliaces for you too, weird how different it is across platforms! I guess if its working cross-platform at the moment it makes sense to keep.

@h-mayorquin
Copy link
Collaborator Author

I will merge this as someone in #3236 is asking for this.

@h-mayorquin h-mayorquin merged commit 6f63f76 into SpikeInterface:main Jul 31, 2024
15 checks passed
@h-mayorquin h-mayorquin deleted the patch_widgets branch July 31, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working widgets Related to widgets module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants