fix:DEV-846/vertically misaligned buttons in wallet popup on in spiri… #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evele
reviewed
Dec 30, 2021
sourabh7047
force-pushed
the
fix/DEV-846-vertically-misaligned-buttons-in-wallet-popup-on-in-spirit-page
branch
2 times, most recently
from
88b9cc4 to
5c81729
Compare
sourabh7047
force-pushed
the
fix/DEV-846-vertically-misaligned-buttons-in-wallet-popup-on-in-spirit-page
branch
from
5c81729 to
f1683be
Compare
…-wallet-popup-on-in-spirit-page
sourabh7047
requested review from
evele,
Markkos89,
acrylicfiddle,
nicocarballo21 and
nico-limo
and removed request for
Markkos89,
evele,
acrylicfiddle and
nicocarballo21
…-wallet-popup-on-in-spirit-page
evele
suggested changes
Jan 13, 2022
| @@ -2963,11 +2964,14 @@ var PanelBody = function (_a) { | |||
| React__default['default'].createElement(MenuWrapper, null, | |||
| iconElement, | |||
| React__default['default'].createElement(LinkLabelMemo, { isPushed: isPushed, inSpirit: inSpiritLinks }, entry.label), | |||
| entry.newIcon ? React__default['default'].createElement(NewIcon, null) : null)))); | |||
There was a problem hiding this comment.
this shouln't be changed the right code it's the one on the line 2966
evele
suggested changes
Jan 13, 2022
| ]; | ||
| if (isMobile) { | ||
| connectors.push({ | ||
| title: "Trust Wallet", | ||
| icon: Icon$1t, | ||
| connectorId: exports.ConnectorNames.Injected, |
There was a problem hiding this comment.
same here, this shouldn't change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX:DEV-846 vertically misaligned buttons in wallet popup on in spirit page
Description
-misalignment of "View of FTM scan" button
Screenshots
Before
After