Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ICreatesObservableForProperty checks from WiXUiBootstrapperTests #241

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rzhw
Copy link
Contributor

@rzhw rzhw commented Feb 27, 2014

This reduces the failing tests from 23 to 18.

I'm not absolutely certain what ICreatesObservableForProperty is around in the code for now, but given the summary in ReactiveUI/RegisterableInterfaces.cs:

/// <summary>
/// ICreatesObservableForProperty represents an object that knows how to
/// create notifications for a given type of object. Implement this if you
/// are porting RxUI to a new UI toolkit, or generally want to enable WhenAny
/// for another type of object that can be observed in a unique way.
/// </summary>

and that the tests in WhenAnyTests all pass, as well as the use of WhenAny for only IReactiveNotifyPropertyChangeds i.e. being covered by WhenAnyShim, it looks like things are safe

The tests will pass without these lines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant