Remove ICreatesObservableForProperty checks from WiXUiBootstrapperTests #241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the failing tests from 23 to 18.
I'm not absolutely certain what ICreatesObservableForProperty is around in the code for now, but given the summary in ReactiveUI/RegisterableInterfaces.cs:
and that the tests in
WhenAnyTests
all pass, as well as the use of WhenAny for onlyIReactiveNotifyPropertyChanged
s i.e. being covered byWhenAnyShim
, it looks like things are safe