Merge pull request #1823 from sebastian-jtl/TLS13_support

TLS 1.3 support
Squirrel · Jul 13, 2022 · 5ee2566 · 5ee2566
2 parents e298270 + 0ef729a
commit 5ee2566
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/src/Squirrel/Utility.cs b/src/Squirrel/Utility.cs
@@ -104,8 +104,15 @@ public static string CalculateStreamSHA1(Stream file)
 
         public static WebClient CreateWebClient()
         {
-            // WHY DOESNT IT JUST DO THISSSSSSSS
-            System.Net.ServicePointManager.SecurityProtocol = SecurityProtocolType.Tls12 | SecurityProtocolType.Tls11 | SecurityProtocolType.Tls;
+            // enable TLS support
+            // TLS 1.0 and 1.1 are enabled for backward compatibility and should be disabled in the future
+            // for security reasons
+            ServicePointManager.SecurityProtocol |=
+                SecurityProtocolType.Tls12 |
+                SecurityProtocolType.Tls11 |
+                SecurityProtocolType.Tls;
+            // disable SSLv3 support for security reasons
+            ServicePointManager.SecurityProtocol &= ~SecurityProtocolType.Ssl3;
 
             var ret = new WebClient();
             var wp = WebRequest.DefaultWebProxy;