Add support for language neutral VersionInfo in target .exes #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anaisbetts, here is the first part of the original .net core PR (#1692), simply adding support for language neutral exes which then covers the .net core launcher exes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A partial fix for #1644, by adding support for language neutral VersionInfo entry, rather than just en-US.
Consumers who wish to use this will need to add the SquirrelAware attribute to the .net core exe as a post build step using a tool like rcedit (already present in the squirrel library).
The fully automated solution for #1644 is still under discussion in #1692.
@ComtelJeremy