Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Documentation in Conformance to the Documentation Guide #25

Merged
merged 11 commits into from
Oct 8, 2023

Conversation

vishnuravi
Copy link
Member

Update Documentation in Conformance to the Documentation Guide

♻️ Current situation & Problem

See issue #16.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #25 (16352af) into main (e0b11e1) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   72.65%   72.65%           
=======================================
  Files          14       14           
  Lines         797      797           
=======================================
  Hits          579      579           
  Misses        218      218           
Files Coverage Δ
Sources/SpeziOnboarding/ConsentView.swift 88.47% <ø> (ø)
...eziOnboarding/OnboardingFlow/OnboardingStack.swift 83.34% <ø> (ø)
...oarding/OnboardingFlow/OnboardingViewBuilder.swift 53.85% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0b11e1...16352af. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the documentation improvements @vishnuravi!
The screenshots and the examples look great 🚀

I took a look at the PR and updated a few things in the following commit: fceaae8.
Fixes some warnings when the documentation is created including missing links as well as the issue that the dark mode ~dark prefix is needed to ensure the the views are automatically displayed in the dark mode.

If you are happy with the PR state, feel free to merge the PR 👍

@vishnuravi
Copy link
Member Author

Thank you for the documentation improvements @vishnuravi! The screenshots and the examples look great 🚀

I took a look at the PR and updated a few things in the following commit: fceaae8. Fixes some warnings when the documentation is created including missing links as well as the issue that the dark mode ~dark prefix is needed to ensure the the views are automatically displayed in the dark mode.

If you are happy with the PR state, feel free to merge the PR 👍

Great, thank you @PSchmiedmayer!

@vishnuravi vishnuravi merged commit 13efb08 into main Oct 8, 2023
7 checks passed
@vishnuravi vishnuravi deleted the documentation branch October 8, 2023 17:35
@PSchmiedmayer PSchmiedmayer added the documentation Improvements or additions to documentation label Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants