refactor(core): ♻️ re-implement VE action icon

StarCitizenTools · May 6, 2024 · a81bf1f · a81bf1f
1 parent 9a403ee
commit a81bf1f
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 19 deletions.
diff --git a/includes/Hooks/SkinHooks.php b/includes/Hooks/SkinHooks.php
@@ -417,10 +417,7 @@ private static function updateViewsMenu( &$links ) {
 			'edit' => 'edit',
 			'view-foreign' => 'linkExternal',
 			// Extension:VisualEditor
-			// For some reason the icon span element keeps getting removed
-			// So we are adding this the legacy way
-			// Bug: T323188
-			// 've-edit' => 'edit',
+			've-edit' => 'edit',
 			// Extension:DiscussionTools
 			'addsection' => 'speechBubbleAdd'
 		];

diff --git a/resources/skins.citizen.styles/components/Pagetools.less b/resources/skins.citizen.styles/components/Pagetools.less
@@ -171,7 +171,6 @@
 		}
 	}
 
-	> a,
 	.citizen-ui-icon {
 		&::before {
 			filter: invert( 1 );
@@ -184,18 +183,6 @@
 // VE styles shouldn't be core but it is just a few lines :/
 #ca-ve-edit {
 	order: 98; // Before source edit
-
-	> a {
-		// See SkinHooks.php for why VE is here
-		&::before {
-			width: var( --size-icon );
-			height: var( --size-icon );
-			content: '';
-			background-repeat: no-repeat;
-			background-position: center;
-			background-size: var( --size-icon );
-		}
-	}
 }
 
 #ca-edit {

diff --git a/skin.json b/skin.json
@@ -19,6 +19,11 @@
 			"Disabled": [
 				"citizen"
 			]
+		},
+		"VisualEditor": {
+			"IconSkins": [
+				"citizen"
+			]
 		}
 	},
 	"ValidSkinNames": {
@@ -277,8 +282,7 @@
 			"selector": "{name}",
 			"defaultColor": "#000",
 			"images": {
-				".citizen-toc__top:before": "resources/skins.citizen.icons/backToTop.svg",
-				"#ca-ve-edit > a:before": "resources/skins.citizen.icons/wmui/edit.svg"
+				".citizen-toc__top:before": "resources/skins.citizen.icons/backToTop.svg"
 			}
 		},
 		"skins.citizen.icons.wmui": {