fixing unititialized BIGNUMs

Stealth-R-D-LLC · Oct 20, 2018 · 4eb5c16 · 4eb5c16
1 parent 85eafd6
commit 4eb5c16
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/key.cpp b/src/key.cpp
@@ -375,8 +375,12 @@ bool CKey::Sign(uint256 hash, std::vector<unsigned char>& vchSig)
     if (BN_cmp(sig_s, halforder) > 0)
     {
         BIGNUM *sig_r_new, *sig_s_new;
+        sig_r_new = BN_new();
+        sig_s_new = BN_new();
         // enforce low S values, by negating the value (modulo the order) if above order/2.
         BN_sub(sig_s_new, order, sig_s);
+        // no need to free sig_*_new according to OpenSSL docs
+        // https://www.openssl.org/docs/man1.1.0/crypto/ECDSA_SIG_set0.html
         BN_copy(sig_r_new, sig_r);
         ECDSA_SIG_set0(sig, sig_r_new, sig_s_new);
     }