보호소 정보 수정 API 추가 #151
Merged
보호소 정보 수정 API 추가 #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
xGreenNarae
approved these changes
Oct 17, 2023
| @@ -23,6 +25,12 @@ public Response<ShelterProfilePage> getShelter(@PathVariable @Min(0) final Integ | |||
| return Response.success(shelterService.getShelterProfile(shelterId, page)); | |||
| } | |||
|
|
|||
| @PutMapping("/{shelterId}") | |||
| public Response<ShelterUpdateSuccessDto> updateShelter(@PathVariable @Min(0) final Integer shelterId, | |||
There was a problem hiding this comment.
수정 권한을 검사하는 부분이 빠진 것 같아요.
이런곳에서 실수가 발생하지 않게 URL Prefix 기반으로 한 곳에서 관리할 수 있는 기능을 추가해봐도 괜찮다는 생각 중인데,, 아니면 익숙한 Spring Security로 교체해도 좋을 것 같구요.
| Shelter shelter = shelterRepository.findById(shelterId).orElseThrow( | ||
| () -> new NotFound404("해당하는 보호소가 존재하지 않습니다.") | ||
| ); | ||
|
|
There was a problem hiding this comment.
마찬가지로 Service 로직 어딘가에서 요청한 계정이 Dto에 담긴 Shelter Id에 대한 수정권한이 있는지 확인해줄 필요가 있을 듯 ? ?
|
|
||
| assertThat(shelterUpdateSuccessDto.getShelterId()).isEqualTo(shelter.getId()); | ||
| assertThat(shelter.getName()).isEqualTo(shelterUpdateDto.name()); | ||
| assertThat(shelter.getAddress().getCity()).isEqualTo(shelterUpdateDto.shelterAddressUpdateDto().city()); |
There was a problem hiding this comment.
다른 이유가 있었던게 아니라면, assertAll 사용할만한 부분인듯요 !
|
xGreenNarae
approved these changes
Oct 17, 2023
| Shelter shelter = shelterRepository.findById(shelterId).orElseThrow( | ||
| () -> new NotFound404("해당하는 보호소가 존재하지 않습니다.") | ||
| ); | ||
|
|
||
| if (!shelter.getAccount().getEmail().equals(account.getEmail())) { |
There was a problem hiding this comment.
맞는데.. 여기서는 ID(PK)가 아닌 Email로 비교를 하셨네요 ??
아무 문제 없지만, Email은 아무튼 Entity간에 연결지점이자 식별자가 아니라 필드일뿐이니까,,
나중에 무슨무슨 이유로 Email이 변경될 수 있게하자! 라고 기능이 바뀐다면, 이 코드를 찾아와야 하지 않을까 라는 생각들을 해본건데..
그럴일은 없다고 생각하는 걸로도 충분하다고 생각합니다 ㅎ.ㅎ 🤡
Test Coverage Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
기타
Close #143