Province Enum 입력 값에 대한 유연한 처리(제주, 제주도, 제주특별자치도 등) #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Coverage Report
|
xGreenNarae
commented
Nov 5, 2023
| 제주특별자치도; | ||
| 제주; | ||
|
|
||
| @JsonCreator(mode = JsonCreator.Mode.DELEGATING) |
There was a problem hiding this comment.
@RequestBody 입력에 대해서는 @JsonCreator 를 타고 Deserialize 된다고 합니다.
| @@ -22,6 +24,7 @@ public class ShelterAddress { | |||
| private double y; | |||
|
|
|||
| @NotNull | |||
| @Enumerated(EnumType.STRING) | |||
| @Override | ||
| public Province convert(final String source) { | ||
| return Province.fromJson(source); | ||
| } |
There was a problem hiding this comment.
@RequestParam 입력에 대한 처리입니다. - 1
| @Override | ||
| public void addFormatters(final FormatterRegistry registry) { | ||
| registry.addConverter(new ProvinceConverter()); | ||
| } |
There was a problem hiding this comment.
@RequestParam 입력에 대한 처리입니다. - 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
@JsonCreator와 Converter 를 사용해서 처리했습니다.@Enumetrated String설정 추가했습니다(기존 데이터도 모두 변경)Close #240 ,
Close #241