Google Docs 링크 연동 API 구현 #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JS970
commented
Oct 14, 2023
•
JS970
commented
- 작업내용
- Google Docs 링크 연동 entity, repo 설계 #103
- Google Docs 링크 연동 Controller 및 Service logic 구현 #104
- TBD
- Google Docs 링크 연동 테스트 #106
- /api/google-docs/registration
- api/google-docs/delete/{docsPageId}
- GoogleDocsApiCreateService - GoogleDocsApiDeleteService
- GooglePageJPARepository.existsByDocumentIdAndUser -
Train0303
reviewed
Oct 15, 2023
Comment on lines
29
to
42
| @Column(name = "document_id", nullable = false) | ||
| private String documentId; | ||
|
|
||
| @ManyToOne(fetch = FetchType.LAZY) | ||
| @JoinColumn(name = "category_id", nullable = false) | ||
| @OnDelete(action = OnDeleteAction.CASCADE) | ||
| private Category category; | ||
|
|
||
| @Column(name = "is_active", nullable = false) | ||
| private Boolean isActive; | ||
|
|
||
| @Column(name = "page_id", nullable = false) | ||
| private String pageId; | ||
|
|
There was a problem hiding this comment.
여기서 documentId와 pageId의 차이점은 무엇인가요???
Train0303
reviewed
Oct 15, 2023
Comment on lines
76
to
97
| private static Credential getCredentials(final NetHttpTransport HTTP_TRANSPORT) | ||
| throws IOException { | ||
| // credentials.json 가져오기 | ||
| InputStream in = GoogleDocsApiBatchService.class.getResourceAsStream(CREDENTIALS_FILE_PATH); | ||
| if (in == null) { | ||
| throw new FileNotFoundException("Resource not found: " + CREDENTIALS_FILE_PATH); | ||
| } | ||
| GoogleClientSecrets clientSecrets = | ||
| GoogleClientSecrets.load(JSON_FACTORY, new InputStreamReader(in)); | ||
|
|
||
| // flow생성 및 유저 인증 요청 처리 | ||
| GoogleAuthorizationCodeFlow flow = new GoogleAuthorizationCodeFlow.Builder( | ||
| HTTP_TRANSPORT, JSON_FACTORY, clientSecrets, SCOPES) | ||
| .setDataStoreFactory(new FileDataStoreFactory(new java.io.File(TOKENS_DIRECTORY_PATH))) | ||
| .setAccessType("offline") | ||
| .build(); | ||
| LocalServerReceiver receiver = new LocalServerReceiver.Builder().setPort(8888).build(); | ||
| Credential credential = new AuthorizationCodeInstalledApp(flow, receiver).authorize("user"); | ||
|
|
||
| // Credential 객체 반환 | ||
| return credential; | ||
| } |
There was a problem hiding this comment.
getCredential은 해당 Service로직에 있기보단, Configuration으로 따로 떼어내 Bean으로 만들어 Credential 객체를 주입받는 형식은 어떠신가요?
Train0303
reviewed
Oct 15, 2023
Comment on lines
+51
to
+59
| public Workspace createDocsWorkspace(String workspaceName, User user) { | ||
| Workspace workspace = workspaceJPARepository.findByUserIdAndWorkspaceName(user.getUserId(), workspaceName) | ||
| .orElseGet(() -> Workspace.builder() | ||
| .workspaceName(workspaceName) | ||
| .user(user) | ||
| .build()); | ||
| workspace.setLinkProvider(LinkProvider.GOOGLE_DOCS); | ||
| return workspaceJPARepository.saveAndFlush(workspace); | ||
| } |
There was a problem hiding this comment.
코드 중복이 생긴다면 createDocsWorkspace가 아닌 createWorkspace로 만들고 인자로 LinkProvider를 받아오면 되지 않을까 싶습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.