#128 공유하기 API (워크스페이스 Post) 기능 구현 #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Train0303
reviewed
Oct 21, 2023
| import java.util.Optional; | ||
|
|
||
|
|
||
| @Transactional(readOnly = true) |
There was a problem hiding this comment.
현재 create와 같은 CUD를 하는 코드인데 @Transactional(readOnly = true)로 설정되어있습니다 @Transaction로 수정하면 좋을 듯 합니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이제 암호화된 워크스페이스id를 path variable로 post요청시, 해당 워크스페이스-카테고리-북마크-태그 정보들이 모두
요청한 유저의 db에 새로 저장됩니다!
해결못한 이슈
북마크들을 가져올때, 항상 마지막 북마크의 태그 리스트는 가져오지 못한다.
즉 A 워크스페이스 안에 a 카테고리가있고 그안에 q,w 북마크가 있고
q북마크에는 l,m 태그, w북마크에는 j,k 태그가 있을경우
A-a-q-l,m 은 잘가져오는데
A-a-w-j,k는 j,k태그까지는 가져오지 못하고, A-a-w 까지만 가져오는 이슈가 있습니다.
일단 배포관련(크램폴린, 도커 , etc...) 공부를 해야되서 이슈는 해결하지 못하고 이렇게 노티만 해드립니다!