ETKF and var4d clean up

StevePny · Dec 20, 2024 · b168ef6 · b168ef6
1 parent 2bc8d41
commit b168ef6
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/dabench/dacycler/_etkf.py b/dabench/dacycler/_etkf.py
@@ -297,7 +297,6 @@ def cycle(self,
             start_time,
             analysis_window,
             n_cycles)
-
 
         # Get the obs vectors for each analysis window
         all_filtered_idx = dac_utils._get_obs_indices(

diff --git a/dabench/dacycler/_var4d_backprop.py b/dabench/dacycler/_var4d_backprop.py
@@ -125,7 +125,7 @@ def _calc_obs_term(self, pred_x, obs_vals, Ht, Rinv):
         pred_obs = pred_x @ Ht
         resid = pred_obs.ravel() - obs_vals.ravel()
 
-        return jnp.sum(resid.T @ Rinv @ resid)
+        return jnp.sum(resid.T @ (Rinv @ resid))
 
     def _make_loss(self, xb0, obs_vals,  Hs, Binv, Rinv,
                    obs_window_indices,