add support for configuring auto topic & subscription creation for th…

…e php-pubsub-google-cloud adapter
Superbalist · Sep 15, 2016 · 32952eb · 32952eb
1 parent d3fb075
commit 32952eb
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/config/config.php b/config/config.php
@@ -57,6 +57,8 @@
             'driver' => 'gcloud',
             'project_id' => null,
             'key_file' => null,
+            'auto_create_topics' => true,
+            'auto_create_subscriptions' => true,
         ],
 
     ],

diff --git a/src/PubSubConnectionFactory.php b/src/PubSubConnectionFactory.php
@@ -110,6 +110,9 @@ protected function makeGoogleCloudAdapter(array $config)
         ];
         $client = $this->container->make('pubsub.gcloud.pub_sub_client', ['config' => $clientConfig]);
 
-        return new GoogleCloudPubSubAdapter($client);
+        $autoCreateTopics = array_get($config, 'auto_create_topics', true);
+        $autoCreateSubscriptions = array_get($config, 'auto_create_subscriptions', true);
+
+        return new GoogleCloudPubSubAdapter($client, $autoCreateTopics, $autoCreateSubscriptions);
     }
 }
diff --git a/tests/PubSubConnectionFactoryTest.php b/tests/PubSubConnectionFactoryTest.php
@@ -166,6 +166,12 @@ public function testMakeGoogleCloudAdapter()
         ];
         $adapter = $factory->make('gcloud', $config);
         $this->assertInstanceOf(GoogleCloudPubSubAdapter::class, $adapter);
+
+        $config['auto_create_topics'] = false;
+        $adapter = $factory->make('gcloud', $config); /** @var GoogleCloudPubSubAdapter $adapter */
+        $this->assertInstanceOf(GoogleCloudPubSubAdapter::class, $adapter);
+        $this->assertFalse($adapter->areTopicsAutoCreated());
+        $this->assertTrue($adapter->areSubscriptionsAutoCreated());
     }
 
     public function testMakeInvalidAdapterThrowsInvalidArgumentException()