Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] 애플 로그인 API 수정 (Email 관련) #215

Merged
merged 1 commit into from
Nov 4, 2024
Merged

[FIX] 애플 로그인 API 수정 (Email 관련) #215

merged 1 commit into from
Nov 4, 2024

Conversation

ChaeAg
Copy link
Member

@ChaeAg ChaeAg commented Nov 2, 2024

Related Issue

Key Changes

  • User 엔티티의 email 필드의 속성을 nullable로 변경
  • 애플 소셜 로그인 시 이메일이 없는 사용자가 있을 수 있어, 애플 소셜 로그인 Request DTO의 email 필드의 속성을 nullable로 변경
    • 이메일이 없는 경우 email 필드를 null로 저장합니다.
    • 기획과의 논의 결과, 해당 상황에서 이메일이 나오는 UI는 이메일이 아예 표시되지 않도록 결정되었습니다~!

To Reviewers

References

rinarina0429
rinarina0429 approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@rinarina0429 rinarina0429 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다ㅏ

@ChaeAg ChaeAg merged commit 045834f into dev Nov 4, 2024
2 checks passed
@ChaeAg ChaeAg deleted the fix/#214 branch November 4, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rinarina0429 rinarina0429 rinarina0429 approved these changes

@Kim-TaeUk Kim-TaeUk Kim-TaeUk approved these changes

Assignees

@ChaeAg ChaeAg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FIX] 애플 로그인 API 수정
3 participants
@ChaeAg @Kim-TaeUk @rinarina0429