Bug fixes in tides, helium giant updates, white dwarf radii and McBGB calculations #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ilyamandel
commented
Nov 30, 2024
ilyamandel
commented
- corrected treatment of rotation to retain pre-mass-loss spin frequency, not angular momentum, on complete envelope removal during stable mass transfer
- fixed issue with updating helium giants that manifested as supernovae with nan core mass (see NaN Values for 'Mass_Core@CO(SN)' with Latest COMPAS (version 03.07.00) #1245 )
…rf radius (resolves issue #1264)
ilyamandel
changed the title
…lowing text above Eq. 44 in Hurley+, 2000 (resolves issue #1256)
ilyamandel
changed the title
added 3 commits
November 30, 2024 16:38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.