Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove question and add new instance template #3092

Merged
merged 3 commits into from
Oct 30, 2023
Merged

chore: remove question and add new instance template #3092

merged 3 commits into from
Oct 30, 2023

Conversation

Bnyro
Copy link
Member

@Bnyro Bnyro commented Oct 30, 2023

No description provided.

@Bnyro Bnyro requested a review from FireMasterK October 30, 2023 17:25
@sweep-ai
Copy link
Contributor

sweep-ai bot commented Oct 30, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

FireMasterK
FireMasterK approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@FireMasterK FireMasterK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@FireMasterK FireMasterK merged commit 39e6833 into TeamPiped:master Oct 30, 2023
5 checks passed
@Bnyro Bnyro deleted the issue-templates branch October 30, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FireMasterK FireMasterK FireMasterK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bnyro @FireMasterK