fix(ios): improve accuracy of ViewPager's onPageScroll parameters

Tencent · Aug 13, 2024 · 39ddeda · 39ddeda
1 parent 50a59ac
commit 39ddeda
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/ios/sdk/component/viewPager/HippyViewPager.m b/ios/sdk/component/viewPager/HippyViewPager.m
@@ -191,14 +191,18 @@ - (void)setPage:(NSInteger)pageNumber animated:(BOOL)animated {
     [self setContentOffset:theItem.frame.origin animated:animated];
     [self invokePageSelected:pageNumber];
 
-    if (self.onPageScrollStateChanged) {
-        if (animated) {
+    if (animated) {
+        if (self.onPageScrollStateChanged) {
             HippyLogTrace(@"[HippyViewPager] settling --- (setPage withAnimation)");
             self.onPageScrollStateChanged(@{ HippyPageScrollStateKey: HippyPageScrollStateSettling });
-        } else {
+        }
+    } else {
+        if (self.onPageScrollStateChanged) {
             HippyLogTrace(@"[HippyViewPager] idle ~~~~~~ (setPage withoutAnimation)");
             self.onPageScrollStateChanged(@{ HippyPageScrollStateKey: HippyPageScrollStateIdle });
         }
+        // Record stop offset for onPageScroll callback
+        [self recordScrollStopOffsetX];
     }
 }