fix(ios): resolve a multithreading issue in Animator

Tencent · Jun 27, 2024 · 9ab6119 · 9ab6119
1 parent 61ea1a1
commit 9ab6119
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/ios/sdk/module/animation2/pop/HPOPAnimator.mm b/ios/sdk/module/animation2/pop/HPOPAnimator.mm
@@ -532,21 +532,21 @@ - (void)_scheduleProcessPendingList
   pthread_mutex_unlock(&_lock);
 }
 
-- (void)_renderTime:(CFTimeInterval)time items:(std::list<POPAnimatorItemRef>)items
+- (void)_renderTime:(CFTimeInterval)time items:(std::list<POPAnimatorItemRef> &)items
 {
   // begin transaction with actions disabled
   [CATransaction begin];
   [CATransaction setDisableActions:YES];
+
+  // lock
+  pthread_mutex_lock(&_lock);
 
   // notify delegate
   NSArray *allDelegates = _animatorDelegates.allObjects;
   for (id<HPOPAnimatorDelegate> delegate in allDelegates) {
     [delegate animatorWillAnimate:self];
   }
 
-  // lock
-  pthread_mutex_lock(&_lock);
-
   // count active animations
   const NSUInteger count = items.size();
   if (0 == count) {