Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vfs): fix VFSUriLoader crash #3521

Closed
wants to merge 2 commits into from
Closed

fix(vfs): fix VFSUriLoader crash #3521

wants to merge 2 commits into from

Conversation

etkmao
Copy link
Collaborator

@etkmao etkmao commented Sep 20, 2023

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@github-actions github-actions bot added module: vfs size: xs Denotes a PR that changes 0-9 lines labels Sep 20, 2023
@hippy-service
Copy link

hippy-service bot commented Sep 20, 2023

Hi, @etkmao. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@wwwcg wwwcg added the action(rebase-merge) Rebase and merge action (maybe privileged) label Sep 20, 2023
@hippy-actions
Copy link

hippy-actions bot commented Sep 20, 2023

🔒 rebase-merge action execution needs privilege escalation.

Please wait for admin team member approval ...

@wwwcg

@wwwcg wwwcg had a problem deploying to github-actions-privileged September 20, 2023 11:50 — with GitHub Actions Failure
@hippy-service
Copy link

hippy-service bot commented Sep 20, 2023

🎉 It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.

@etkmao etkmao force-pushed the bugfix/fix_uri_loader_crash branch from 5776f96 to cba92bf Compare September 20, 2023 11:55
@wwwcg wwwcg force-pushed the bugfix/fix_uri_loader_crash branch from cba92bf to 36b0c2e Compare September 20, 2023 12:14
@wwwcg wwwcg requested a review from ruifanyuan as a code owner September 20, 2023 12:14
@wwwcg wwwcg removed the request for review from ozonelmy September 20, 2023 12:15
@hippy-service
Copy link

hippy-service bot commented Sep 21, 2023

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@ozonelmy ozonelmy enabled auto-merge (rebase) September 21, 2023 02:29
@etkmao etkmao disabled auto-merge September 21, 2023 04:13
@etkmao etkmao enabled auto-merge (squash) September 21, 2023 04:16
@etkmao etkmao closed this Sep 21, 2023
auto-merge was automatically disabled September 21, 2023 04:31

Pull request was closed

@etkmao etkmao deleted the bugfix/fix_uri_loader_crash branch September 21, 2023 04:31
@hippy-actions hippy-actions bot added action(rebase-merge): failed Rebase and merge action execution failed and removed action(rebase-merge) Rebase and merge action (maybe privileged) labels Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruifanyuan ruifanyuan ruifanyuan approved these changes

@wwwcg wwwcg wwwcg approved these changes

@ozonelmy ozonelmy ozonelmy approved these changes

Assignees
No one assigned
Labels
action(rebase-merge): failed Rebase and merge action execution failed module: vfs size: xs Denotes a PR that changes 0-9 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@etkmao @ozonelmy @wwwcg @ruifanyuan @open-hippy