Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): podspec use_framework support bug #3558

Merged
merged 5 commits into from
Oct 23, 2023
Merged

fix(ios): podspec use_framework support bug #3558

merged 5 commits into from
Oct 23, 2023

Conversation

wwwcg
Copy link
Collaborator

@wwwcg wwwcg commented Oct 20, 2023 •
edited
Loading

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@wwwcg wwwcg requested a review from ruifanyuan as a code owner October 20, 2023 11:05
@github-actions github-actions bot added doc: example build: xcode size: s Denotes a PR that changes 10-99 lines labels Oct 20, 2023
@hippy-service
Copy link

hippy-service bot commented Oct 20, 2023

Hi, @wwwcg. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@hippy-service
Copy link

hippy-service bot commented Oct 23, 2023

🎉 It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.

@wwwcg wwwcg added the action(squash-merge) Squash and merge action label Oct 23, 2023
@hippy-actions
Copy link

hippy-actions bot commented Oct 23, 2023

⚠️ squash-merge action execution failed, because of cannot squash and merge your own pull request.

Please check the following details:

(empty response)

@wwwcg

@hippy-actions hippy-actions bot added action(squash-merge): failed Squash and merge action execution failed and removed action(squash-merge) Squash and merge action labels Oct 23, 2023
@wwwcg wwwcg enabled auto-merge (squash) October 23, 2023 11:35
@zealotchen0 zealotchen0 disabled auto-merge October 23, 2023 12:17
@zealotchen0 zealotchen0 merged commit 848ef40 into Tencent:main Oct 23, 2023
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruifanyuan ruifanyuan ruifanyuan approved these changes

Assignees
No one assigned
Labels
action(squash-merge): failed Squash and merge action execution failed build: xcode doc: example size: s Denotes a PR that changes 10-99 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wwwcg @ruifanyuan @zealotchen0 @open-hippy