Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 1.21 #11

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Bump to 1.21 #11

merged 3 commits into from
Oct 17, 2024

Conversation

teo-tsirpanis
Copy link
Member

No description provided.

@teo-tsirpanis teo-tsirpanis marked this pull request as ready for review October 17, 2024 16:22
Copy link
Collaborator

@jdblischak jdblischak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@teo-tsirpanis teo-tsirpanis merged commit ee0bb54 into main Oct 17, 2024
4 checks passed
@teo-tsirpanis teo-tsirpanis deleted the teo/1.21 branch October 17, 2024 17:18
@jdblischak
Copy link
Collaborator

The release from yesterday was confusing. Even though the binary that was attached to the 1.21-0 release was created from ee0bb54, the release page said it was created from an earlier commit. This is because a tag for 1.21-0 was created from an internal branch, and we couldn't delete the protected tag.

To ensure we weren't confused by this in the future, today I had @ihnorton clean this up. Specifically:

  • He deleted the 1.21-0 release from yesterday
  • He deleted the 1.21-0 tag from yesterday
  • He merged Improve robustness of the GitHub Actions workflow. #12, which will prevent this situation from happening again
  • The squashed commit df1a35e triggered a build, and since it was run on main, it created a release and uploaded a binary

So now everything is good:

https://github.com/TileDB-Inc/m2w64-htslib-build/tree/1.21-0
https://github.com/TileDB-Inc/m2w64-htslib-build/releases/tag/1.21-0
https://github.com/TileDB-Inc/m2w64-htslib-build/releases/download/1.21-0/m2w64-htslib-1.21-0.tar.gz

@teo-tsirpanis
Copy link
Member Author

Thanks @ihnorton!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants