-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📝 Add Example Notebook for Foundation Models #887
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
for more information, see https://pre-commit.ci
I just realised that in my code, like in this example notebook, we do not explicitly put the model into the
I got worried that I was using models in tiatoolbox/tiatoolbox/models/architecture/vanilla.py Lines 148 to 178 in 4a1940d
I think this behaviour is as it should be, but maybe adding a message specifying that the models are being put into |
Please remember to update https://github.com/TissueImageAnalytics/tiatoolbox/blob/feature-extractor-example/examples/README.md |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…ImageAnalytics/tiatoolbox into feature-extractor-example
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #887 +/- ##
========================================
Coverage 99.90% 99.90%
========================================
Files 69 69
Lines 8715 8715
Branches 1149 1149
========================================
Hits 8707 8707
Misses 3 3
Partials 5 5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @adamshephard . Please can you re-run the Jupyter notebook. This will update the title on the last image. Please update the feature_extraction.png with the new title. Please crop it to the image area before uploading.
Thanks @GeorgeBatch. As I am now finalising release |
timm
module in TIAToolbox.