Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

background color changed of the toggle button #582

Merged
merged 4 commits into from
Oct 29, 2024

Conversation

sayanp607
Copy link
Contributor

Description

A clear and concise description of what the PR does.
This pr fixes the the background color of the toggle button because previously it was transparent according to @tailwind base.

Related Issues

Fixes: #551

Screenshots (if applicable)

Add any screenshots that help explain or visualize the changes.
Screenshot 2024-10-22 085603

Checklist

Make sure to check off all the items before submitting. Mark with [x] if done.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I am working on this issue under GSSOC

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Suman373 Suman373 added bug Something isn't working level1 gssoc-ext labels Oct 22, 2024
@Suman373
Copy link
Collaborator

@sayanp607 Good work ! @Trisha-tech You may verify and merge it

@Trisha-tech
Copy link
Owner

Description

A clear and concise description of what the PR does. This pr fixes the the background color of the toggle button because previously it was transparent according to @tailwind base.

Related Issues

Fixes: #551

Screenshots (if applicable)

Add any screenshots that help explain or visualize the changes. Screenshot 2024-10-22 085603

Checklist

Make sure to check off all the items before submitting. Mark with [x] if done.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I am working on this issue under GSSOC

Keep the color like other links i.e. white @sayanp607

@sayanp607
Copy link
Contributor Author

Description

A clear and concise description of what the PR does. This pr fixes the the background color of the toggle button because previously it was transparent according to @tailwind base.

Related Issues

Fixes: #551

Screenshots (if applicable)

Add any screenshots that help explain or visualize the changes. Screenshot 2024-10-22 085603

Checklist

Make sure to check off all the items before submitting. Mark with [x] if done.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I am working on this issue under GSSOC

Keep the color like other links i.e. white @sayanp607

kindly, check it now.

@Suman373
Copy link
Collaborator

Description

A clear and concise description of what the PR does. This pr fixes the the background color of the toggle button because previously it was transparent according to @tailwind base.

Related Issues

Fixes: #551

Screenshots (if applicable)

Add any screenshots that help explain or visualize the changes. Screenshot 2024-10-22 085603

Checklist

Make sure to check off all the items before submitting. Mark with [x] if done.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I am working on this issue under GSSOC

Keep the color like other links i.e. white @sayanp607

kindly, check it now.

Provide a screenshot of the change please.

@sayanp607
Copy link
Contributor Author

Description

A clear and concise description of what the PR does. This pr fixes the the background color of the toggle button because previously it was transparent according to @tailwind base.

Related Issues

Fixes: #551

Screenshots (if applicable)

Add any screenshots that help explain or visualize the changes. Screenshot 2024-10-22 085603

Checklist

Make sure to check off all the items before submitting. Mark with [x] if done.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I am working on this issue under GSSOC

Keep the color like other links i.e. white @sayanp607

kindly, check it now.

Provide a screenshot of the change please.

Screenshot 2024-10-22 230644

@Suman373
Copy link
Collaborator

LGTM !

@Trisha-tech
Copy link
Owner

Description

A clear and concise description of what the PR does. This pr fixes the the background color of the toggle button because previously it was transparent according to @tailwind base.

Related Issues

Fixes: #551

Screenshots (if applicable)

Add any screenshots that help explain or visualize the changes. Screenshot 2024-10-22 085603

Checklist

Make sure to check off all the items before submitting. Mark with [x] if done.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I am working on this issue under GSSOC

Keep the color like other links i.e. white @sayanp607

kindly, check it now.

Provide a screenshot of the change please.

Screenshot 2024-10-22 230644

I want only lines as the toggle button not the circle encircled it. @sayanp607

@sayanp607
Copy link
Contributor Author

Description

A clear and concise description of what the PR does. This pr fixes the the background color of the toggle button because previously it was transparent according to @tailwind base.

Related Issues

Fixes: #551

Screenshots (if applicable)

Add any screenshots that help explain or visualize the changes. Screenshot 2024-10-22 085603

Checklist

Make sure to check off all the items before submitting. Mark with [x] if done.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I am working on this issue under GSSOC

Keep the color like other links i.e. white @sayanp607

kindly, check it now.

Provide a screenshot of the change please.

Screenshot 2024-10-22 230644

I want only lines as the toggle button not the circle encircled it. @sayanp607

Yes, I made it now like that.
Screenshot 2024-10-23 141337

@sayanp607
Copy link
Contributor Author

Description

A clear and concise description of what the PR does. This pr fixes the the background color of the toggle button because previously it was transparent according to @tailwind base.

Related Issues

Fixes: #551

Screenshots (if applicable)

Add any screenshots that help explain or visualize the changes. Screenshot 2024-10-22 085603

Checklist

Make sure to check off all the items before submitting. Mark with [x] if done.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I am working on this issue under GSSOC

Keep the color like other links i.e. white @sayanp607

kindly, check it now.

Provide a screenshot of the change please.

Screenshot 2024-10-22 230644

I want only lines as the toggle button not the circle encircled it. @sayanp607

Yes, I made it now like that. Screenshot 2024-10-23 141337

Is it ok now? @Trisha-tech

@Trisha-tech Trisha-tech merged commit c0bd656 into Trisha-tech:master Oct 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc-ext level1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Improve the styling of toggle button
3 participants