Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor tidy up, and skip the tests if no file is found. #295

Merged
merged 4 commits into from
May 16, 2023
Merged

Minor tidy up, and skip the tests if no file is found. #295

merged 4 commits into from
May 16, 2023

Conversation

samcunliffe
Copy link
Member

Context/Description

Possibly overkill but in the interest of small PRs (cough cough). Here is a tweak to your small data sample unit tests which skips them if the data not found. This is a PR against our draft branch from Friday (so you know what I'm proposing).

Still TODO: decide whether to provide instructions to generate them here in the logging. What do you think?

Testing

Checked locally with

➤ mv ../tdms/tests/unit/benchmark_scripts/unit_test_data ../tdms/tests/unit/benchmark_scripts/_unit_test_data
➤ ./tdms_tests

< ... blah blah ...>

===============================================================================
test cases:  51 |  43 passed | 8 skipped
assertions: 904 | 904 passed

➤ mv ../tdms/tests/unit/benchmark_scripts/_unit_test_data ../tdms/tests/unit/benchmark_scripts/unit_test_data
➤ ./tdms_tests

< ... blah blah ...>

===============================================================================
All tests passed (944 assertions in 51 test cases)

samcunliffe and others added 2 commits May 15, 2023 09:42
@samcunliffe
Update catch2 (#275)
25d9df0 
* Update catch2.

v3.3 has some nice features. Including a SKIP() macro. 💙

* Skip the segfault test.
@samcunliffe
SKIP unit tests if sample data not generated.
84155f5 
Since we're introducing a bit of complexity into the unit-testing
framework, at least we should skip the tests (developer quality of
life) with a nice warning explaining why.
@samcunliffe samcunliffe added the testing Adding or requesting more test coverage label May 15, 2023
@samcunliffe samcunliffe requested a review from willGraham01 May 15, 2023 10:17
@samcunliffe @willGraham01
Skip function.
e87636a 
2 lines → 1. And gets rid of another global.

Co-authored-by: willGraham01 <[email protected]>
@samcunliffe samcunliffe merged commit 02d04a8 into 181-pairdev-write-dataset-to-group May 16, 2023
@samcunliffe samcunliffe deleted the 181-pairdev-tidyup-plus-skip-tests branch May 16, 2023 15:55
willGraham01 added a commit that referenced this pull request May 19, 2023
@samcunliffe @willGraham01
Minor tidy up, and skip the tests if no file is found. (#295)
a8d6b56 
* Update catch2 (#275)

* Update catch2.

v3.3 has some nice features. Including a SKIP() macro. 💙

* Skip the segfault test.

* SKIP unit tests if sample data not generated.

Since we're introducing a bit of complexity into the unit-testing
framework, at least we should skip the tests (developer quality of
life) with a nice warning explaining why.

* Skip function.

2 lines → 1. And gets rid of another global.

Co-authored-by: willGraham01 <[email protected]>

* Revert to explicitly skipping the broken test.

---------

Co-authored-by: willGraham01 <[email protected]>
willGraham01 added a commit that referenced this pull request May 19, 2023
@samcunliffe @willGraham01
Minor tidy up, and skip the tests if no file is found. (#295)
f3a8671 
* Update catch2 (#275)

* Update catch2.

v3.3 has some nice features. Including a SKIP() macro. 💙

* Skip the segfault test.

* SKIP unit tests if sample data not generated.

Since we're introducing a bit of complexity into the unit-testing
framework, at least we should skip the tests (developer quality of
life) with a nice warning explaining why.

* Skip function.

2 lines → 1. And gets rid of another global.

Co-authored-by: willGraham01 <[email protected]>

* Revert to explicitly skipping the broken test.

---------

Co-authored-by: willGraham01 <[email protected]>
@samcunliffe samcunliffe mentioned this pull request Jun 5, 2023
Closed
@samcunliffe samcunliffe restored the 181-pairdev-tidyup-plus-skip-tests branch June 5, 2023 14:35
@willGraham01 willGraham01 deleted the 181-pairdev-tidyup-plus-skip-tests branch June 6, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willGraham01 willGraham01 willGraham01 approved these changes

Assignees
No one assigned
Labels
testing Adding or requesting more test coverage
Projects
None yet
Milestone
v1.1 Removing MATLAB C++ header depen...
Development

Successfully merging this pull request may close these issues.
2 participants
@samcunliffe @willGraham01