Make setuptools-scm
look for versions only in v[digit] prefixed tags
#1564
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve #1561
Changes
setuptools_scm
configuration optiongit_describe_command
from default value which uses glob pattern*[0-9]*
to match possible versions from tags to instead use more specific glob patternv[0-9]*
which will only match tags which start withv
then a digit which should hopefully avoid spurious matches such as toprof1
which was causing issue in #1561. With this change runningpython -m setuptools_scm
locally succeeds (while was previously failing) as does runningtox -e check
.