Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make setuptools-scm look for versions only in v[digit] prefixed tags #1564

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

matt-graham
Copy link
Collaborator

Should resolve #1561

Changes setuptools_scm configuration option git_describe_command from default value which uses glob pattern *[0-9]* to match possible versions from tags to instead use more specific glob pattern v[0-9]* which will only match tags which start with v then a digit which should hopefully avoid spurious matches such as to prof1 which was causing issue in #1561. With this change running python -m setuptools_scm locally succeeds (while was previously failing) as does running tox -e check.

@matt-graham matt-graham requested a review from tamuri January 7, 2025 10:02
@matt-graham matt-graham merged commit a23189d into master Jan 7, 2025
62 checks passed
@matt-graham matt-graham deleted the mmg/setuptools-scm-tag-fix branch January 7, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

local Run checks with tox
2 participants