Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-compile patch & build instructions #710

Merged
merged 7 commits into from
Dec 8, 2024
Merged

Conversation

UE4SS
Copy link
Collaborator

@UE4SS UE4SS commented Dec 7, 2024

Description

Changes to enable cross-compilation with msvc-wine.

How Has This Been Tested?

Follow the build instructions, which can be found in README.md included in this pull request.

Checklist

  • I have made corresponding changes to the documentation.

UE4SS added 4 commits December 7, 2024 15:58
This selects the cross-compilation toolchain for UE4SS.
Valid values are 'msvc-wine' and 'None', and it defaults to 'None' if '--ue4ssCross' isn't used.
Without this task, you'd have to cd into deps/first/patternsleuth_bind and execute the command manually before invoking the xmake build command.
Copy link
Contributor

github-actions bot commented Dec 7, 2024

MSVC-Game__Debug__Win64 Download Logs
Build Details
Name Information
PR Commit 905e014
Merge Commit 1a3dac9
Size 46.41 MB
Last Updated Dec 8, 24, 8:02:16 PM UTC
Expires At Dec 22, 24, 8:02:11 PM UTC

MSVC-Game__Shipping__Win64 Download Logs
Build Details
Name Information
PR Commit 905e014
Merge Commit 1a3dac9
Size 28.16 MB
Last Updated Dec 8, 24, 8:05:34 PM UTC
Expires At Dec 22, 24, 8:05:31 PM UTC

@UE4SS
Copy link
Collaborator Author

UE4SS commented Dec 7, 2024

There were some last minute fixes.
This should be ready to be tested now.

@igromanru
Copy link
Contributor

igromanru commented Dec 8, 2024

Since you got a lot of if there, if it runs in wine, I guess windows shouldn't be affected at all right?
However, I've successfully compiled the branch in Windows 11 Pro 23H2.

@UE4SS
Copy link
Collaborator Author

UE4SS commented Dec 8, 2024

Since you got a lot of if there, if it runs in wine, I guess windows shouldn't be affected at all right? However, I've successfully compiled the branch in Windows 11 Pro 23H2.

Yeah, for some reason checking against the default value of the option doesn't work so now we're checking if the option isn't msvc-wine to detect non-cross builds.
CI is passing, and msvc-wine works for me on Arch Linux, so this should be good to go, though it would be good if someone else could test this on Linux just to make sure it's working on more machines than mine.

Copy link
Member

@Buckminsterfullerene02 Buckminsterfullerene02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the instructions and was able to easily (aside from one error, which was an easy fix and is now in the PR) build the project on arch linux.

I tested the compiled binaries on windows and it works. I tested kismet debugger, pressed the various generator buttons and checked live view, all work as expected.

@UE4SS UE4SS merged commit c27728b into main Dec 8, 2024
14 checks passed
@narknon narknon deleted the cross-compile-working2-cleaner branch December 19, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants