Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain disabled state in RMREAS, RMMODE, NOT on postback #225

Merged
merged 7 commits into from
Dec 18, 2024

Conversation

Oddvocado
Copy link
Member

@Oddvocado Oddvocado commented Dec 12, 2024

Fixes #220

This update addresses an issue where the RMREAS, RMMODE, and NOT properties were incorrectly enabled when a form was submitted as "Finalized." To resolve this, a CSS class named never-enabled was added. This class overrides the valid class applied by jQuery validation during an HTTP POST request.

To test this fix:

  • Submit a form containing validation errors.
  • When the page reloads with errors displayed, ensure that the RMREAS, RMMODE, and NOT properties remain in their disabled state.

image

All forms use this partial, so multiple forms will need to be tested during review to ensure consistent behavior.

@Oddvocado Oddvocado self-assigned this Dec 12, 2024
@Oddvocado Oddvocado marked this pull request as ready for review December 12, 2024 17:08
@ashleybot ashleybot self-requested a review December 17, 2024 13:49
@ashleybot
Copy link
Member

The CSS file has indent changes on almost every line, so commenting the actual change for this PR here for posterity:

.valid.never-enable {
    color: rgb(156 163 175) !important;
  }

Copy link
Member

@ashleybot ashleybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Oddvocado Tested both forms where the dropdown are enabled (remote is allowed) and disabled (remote is not allowed)

Also tested when form is required and not completed reason is disabled.

All scenarios follow the spec outlined in the card!

  • A1 (remote allowed, optional)
  • B1 (remote not allowed, optional)

@ashleybot
Copy link
Member

@Oddvocado Friendly reminder to merge main into your feature branch, build and test. And then bump the patch version up before merging your feature into main.

@ashleybot
Copy link
Member

@Oddvocado Main needs to be merged into this feature branch. As of right now, next patch version is 4.6.4.

@Oddvocado Oddvocado merged commit 047e56c into main Dec 18, 2024
4 checks passed
@Oddvocado Oddvocado deleted the quick-remain-disable-footer-selects branch December 18, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintain disabled state in RMREAS, RMMODE, NOT on postback
2 participants