-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintain disabled state in RMREAS, RMMODE, NOT on postback #225
Conversation
The CSS file has indent changes on almost every line, so commenting the actual change for this PR here for posterity:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Oddvocado Tested both forms where the dropdown are enabled (remote is allowed) and disabled (remote is not allowed)
Also tested when form is required and not completed reason is disabled.
All scenarios follow the spec outlined in the card!
- A1 (remote allowed, optional)
- B1 (remote not allowed, optional)
@Oddvocado Friendly reminder to merge main into your feature branch, build and test. And then bump the patch version up before merging your feature into main. |
@Oddvocado Main needs to be merged into this feature branch. As of right now, next patch version is |
Fixes #220
This update addresses an issue where the RMREAS, RMMODE, and NOT properties were incorrectly enabled when a form was submitted as "Finalized." To resolve this, a CSS class named never-enabled was added. This class overrides the valid class applied by jQuery validation during an HTTP POST request.
To test this fix:
All forms use this partial, so multiple forms will need to be tested during review to ensure consistent behavior.