Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epa header conflict with plotly #96

Merged
merged 6 commits into from
Sep 15, 2023

Conversation

cristinamullin
Copy link
Collaborator

@cristinamullin cristinamullin commented Sep 7, 2023

This will fix the plotly conflict but messes up the EPA header drastically because it simply just comments out the line that causes the issue. We still need a solution (updated file/link) for this. Here is the link that causes the plotly conflicts: https://www.epa.gov/themes/epa_theme/css/styles.css?r6lsex

This also updates the EPA header with the updated template Brad Cooper (ERG) shared, but that was a separate issue. This substitution does not seem to change anything about the look and feel (no clear difference in anything after substituting it in). I substituted this https://www.epa.gov/themes/epa_theme/pattern-lab/?p=pages-standalone-template in in place of https://www.epa.gov/themes/epa_theme/pattern-lab/.markup-only.html. Need to confirm this is the right place to use the updated link.

comment out issue line and update pattern lab theme, see: #52
@cristinamullin cristinamullin linked an issue Sep 7, 2023 that may be closed by this pull request
@cristinamullin
Copy link
Collaborator Author

cristinamullin commented Sep 11, 2023

Review and consider using style.css file that Garret Stillings shared: https://github.com/USEPA/NARS-Data-Download-Tool/tree/main/www

@cristinamullin
Copy link
Collaborator Author

image

I made some changes to reference the style css locally. I added two files, styles2.css which is a copy of the code from https://www.epa.gov/themes/epa_theme/css/styles.css?r6lsex and styles.css which is a copy of the css file used in another OW R Shiny app that Stillings, Garrett shared: https://github.com/USEPA/NARS-Data-Download-Tool/tree/main/www. Currently in the branch it now references styles.css but the header still doesn't look right.

@cristinamullin
Copy link
Collaborator Author

removing problematic css files and commenting out style for now. Will create a new branch to fix header/footer

@cristinamullin cristinamullin merged commit b812163 into develop Sep 15, 2023
@cristinamullin cristinamullin deleted the epa-header-conflict-with-plotly branch September 15, 2023 18:23
@cristinamullin cristinamullin mentioned this pull request Sep 15, 2023
triphook pushed a commit that referenced this pull request May 16, 2024
triphook pushed a commit that referenced this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom EPA CSS conflicts with usability of leaflet, plotly
1 participant