Add a hollowcuboid iteration helper #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HybridDog
force-pushed
the
m_hollowcube_iter
branch
from
9c9ca1d to
0a2483c
Compare
HybridDog
force-pushed
the
m_hollowcube_iter
branch
from
0a2483c to
95c29ea
Compare
|
I added tests in 456ce8c. Can you rebase so the CI runs? |
HybridDog
force-pushed
the
m_hollowcube_iter
branch
from
95c29ea to
2a90a1d
Compare
|
It's rebased now and I've fixed problems in worldedit.cube. Thanks for the tests. |
sfan5
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the area index calculation in the worldedit.cube function.
The hollowcuboid code is from https://github.com/minetest/minetest/pull/4479/files.
I did not notice a performance change, probably because there is much overhead. (I use the chatcommand_delays mod.)
Please test this (also for very small hollow cubes).