feat: refactor dutch reactor tests #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move common tests into a base test contract - inherit it from Dutch and ExclusiveDutch (dutchv2 coming later) - clean up test logic, use helpers and solarray
marktoda
force-pushed
the
dutch-test-refactor
branch
from
99090c6 to
612396e
Compare
marktoda
commented
Dec 19, 2023
| (order,) = createAndSignDutchOrder(request); | ||
| } | ||
|
|
||
| function test_dutch_resolveOutputNotStarted() public { |
There was a problem hiding this comment.
fyi all these tests come from the validation section of DutchOrderReactorTest, but they've been cleaned up and refactored into this abstract test file which can be imported by any reactor test to add coverage to any dutch decaying order types
hensha256
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve the basic problem of reactors often having similar logic, and missing coverage due to assumptions that logic is the same so it should work the same. ExclusiveDutchReactor was missing a lot of coverage over the dutch validation for this reason