bitwise optimizations #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snreynolds
force-pushed
the
optimizations
branch
from
cedb045 to
d865412
Compare
hensha256
reviewed
Nov 10, 2022
| } | ||
|
|
||
| /// @notice Checks whether a nonce is taken and sets the bit at the bit position in the bitmap at the word position | ||
| /// @param from The address to use the nonce at | ||
| /// @param nonce The nonce to spend | ||
| function _useUnorderedNonce(address from, uint256 nonce) internal { | ||
| (uint256 wordPos, uint256 bitPos) = bitmapPositions(nonce); | ||
| uint256 bitmap = nonceBitmap[from][wordPos]; | ||
| uint256 bit = 1 << bitPos; | ||
| uint256 flipped = nonceBitmap[from][wordPos] ^= bit; |
There was a problem hiding this comment.
woah this is so smart. love it
There was a problem hiding this comment.
Smart, yes, but this approach runs counter to the Checks-Effects-Interactions pattern by switching the order of the checks and the effects.
It's also not super intuitive what the order of operations is - I opened an issue about this: #217
hensha256
approved these changes
Nov 10, 2022
marktoda
approved these changes
Nov 10, 2022
test/NonceBitmap.t.sol
Outdated
| @@ -13,6 +13,12 @@ contract NonceBitmapTest is Test { | |||
| permit2 = new MockPermit2(); | |||
| } | |||
|
|
|||
| function testNonceLLL() public { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.