Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/build ios #17

Merged
merged 8 commits into from
Jul 16, 2024
Merged

Feature/build ios #17

merged 8 commits into from
Jul 16, 2024

Conversation

tonelli-m
Copy link
Collaborator

@tonelli-m tonelli-m commented Jul 15, 2024

Description

Make app compile and run on iOS (setup for simulator only for now, shared setup for physical devices will require a paid Apple Account)

Changes

  • Bumped Koin version to 3.5.6 to solve this issue
  • Bumped Appyx to 2.0.1 fix iOS related issues
  • Bumped cocoapods to latest version
  • Use "native" resources management using compose instead of third party library:
    • Updated compose-plugin version to 1.6.11 (latest atm)
    • Use the new default resources management solution instead of third party library
    • Updated directory structure and SpectrumChannelTest::testSpeak to match this new approach
  • Re-enabled iOS github workflow
    • Run shared test suite on iOS simulator
    • Added reports upload for other platforms as well
    • Use upload-artifact@v4 instead of v3

Linked issues

Remaining TODOs

  • Fix UI issues on iOS devices (currently navigation is not properly offseted on notched devices (iPhone X and above))
    • If we get rid off Appyx, maybe we should keep this for a later PR
  • Fix permissions screen (currently the app crashes when user clicks Next)
    • Same as above, can be solved in a later PR
  • Add setup instructions, should also be done for other platforms so perhaps we can group it all in a setup.md PR

Checklist

  • Code compiles correctly on all platforms
  • All pre-existing tests are passing
  • If needed, new tests have been added
  • Extended the README / documentation if necessary
  • Added code has been documented

@tonelli-m tonelli-m added the KMP Shared Kotlin code label Jul 15, 2024
@tonelli-m tonelli-m self-assigned this Jul 15, 2024
@tonelli-m tonelli-m added the iOS iOS related code label Jul 15, 2024
@tonelli-m tonelli-m changed the title WIP: Feature/build ios Draft: Feature/build ios Jul 15, 2024
@tonelli-m tonelli-m marked this pull request as draft July 15, 2024 12:46
@tonelli-m tonelli-m marked this pull request as ready for review July 15, 2024 13:21
- Instead of using a third party library to manage resources in test targets, use the new compose resources system introduced in compose version 1.6.0
@tonelli-m tonelli-m changed the title Draft: Feature/build ios Feature/build ios Jul 15, 2024
@tonelli-m tonelli-m assigned nicolas-f and unassigned tonelli-m Jul 15, 2024
@tonelli-m tonelli-m requested a review from nicolas-f July 15, 2024 15:13
Copy link
Member

@nicolas-f nicolas-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice ! well done

@nicolas-f nicolas-f merged commit 0afe3b7 into main Jul 16, 2024
5 checks passed
@nicolas-f nicolas-f deleted the feature/build-ios branch July 16, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS iOS related code KMP Shared Kotlin code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants