support for non-vector-space (aux) modes in tensorials #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This type trait allows to e.g. static_assert that all requirements of the Tensor interface are fulfilled for a given class.
This reverts commit 4c5e8ea.
Instead of hardcoding two expected LaTeX representations of a given expression, we now do an exhaustive search over all permutation of summands to see if one of them yields the desired permutation. This is acceptable as the order of summands has no practical relevance other than for matching a hard-coded order in a test case. The benefit of doing it this way is reduced maintenance cost in exchange for a runtime performance overhead when running the tests. However, the overhead is expected to be small and for test cases it shouldn't matter anyway.
…alogy with array indexing in programming languages
ajay-mk
reviewed
Nov 19, 2024
Comment on lines
+8
to
+9
| #include "abstract_tensor.hpp" | ||
| #include "expr.hpp" |
There was a problem hiding this comment.
Suggested change
| #include "abstract_tensor.hpp" | |
| #include "expr.hpp" | |
| #include <SeQuant/core/abstract_tensor.hpp> | |
| #include <SeQuant/core/expr.hpp> |
| .def_property_readonly("braket", [](const Tensor &t) { | ||
| auto braket = t.braket(); | ||
| return std::vector<Index>(braket.begin(), braket.end()); | ||
| .def_property_readonly("auxikiary", &Tensor::auxiliary) |
There was a problem hiding this comment.
Suggested change
| .def_property_readonly("auxikiary", &Tensor::auxiliary) | |
| .def_property_readonly("auxiliary", &Tensor::auxiliary) |
Sure, that shouldn't cause issues. I'll just keep replacing |
|
@bimalgaudel imo we shouldn't be hard-coding tensor names. Instead, I would make the CSV/DF functions take the respective tensor names as arguments (that might default to what you have currently hard-coded). This should allow for more flexibility in the future. |
bimalgaudel
force-pushed
the
aux-indices
branch
from
d99163a to
8bc2046
Compare
…s for better cache utilization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
revamp of #177
largely cosmetic touchup (
auxiliary->aux) + merge with master + support for both oldTensorNetworkand newTensorNetworkV2implementations (old TN was made aux-aware and is the temporary default until TNV2 is tested as its replacement).N.B. since in
masterbraandketare reserved for strong typing, the tensor concept dropsbra(t),ket(t)and ``aux(t)` requirements.